Skip to content

upd: Cloud Resource example outputs#82

Merged
hongchaodeng merged 2 commits intomainfrom
brent/update-example-readmes
Oct 22, 2025
Merged

upd: Cloud Resource example outputs#82
hongchaodeng merged 2 commits intomainfrom
brent/update-example-readmes

Conversation

@brent-anyscale
Copy link
Collaborator

The new examples for registering resources for multi-resource clouds did not include the new external-id value. That has been added.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • pre-commit has been run
  • Tests for the changes have been added (for bug fixes / features)
  • All tests passing
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull Request Type

  • Bugfix
  • New feature
  • Refactoring (no functional changes)
  • Documentation change
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Added the common prefix to the output for the name in the yaml file
Ensured that pre-commit executed for README updates.

On branch brent/update-example-readmes
Changes to be committed:
	modified:   README.md
	modified:   outputs.tf
Added the external id to the outputs for the yaml file
Ensured that pre-commit executed for README updates.

On branch brent/update-example-readmes
Changes to be committed:
	modified:   anyscale-v2-commonname/outputs.tf
	modified:   anyscale-v2-privatesubnets/README.md
	modified:   anyscale-v2-privatesubnets/outputs.tf
@brent-anyscale brent-anyscale requested a review from a team as a code owner October 2, 2025 05:03
@github-actions github-actions bot added documentation Improvements or additions to documentation examples labels Oct 2, 2025
@hongchaodeng hongchaodeng merged commit 3a31350 into main Oct 22, 2025
4 checks passed
@hongchaodeng hongchaodeng deleted the brent/update-example-readmes branch October 22, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants